Skip to content

fix(station-login): visibility toggle for desktop login - #554

Merged
mkesavan13 merged 2 commits into
webex:ccwidgetsfrom
mkesavan13:hide-desktop
Nov 21, 2025
Merged

fix(station-login): visibility toggle for desktop login#554
mkesavan13 merged 2 commits into
webex:ccwidgetsfrom
mkesavan13:hide-desktop

Conversation

@mkesavan13

@mkesavan13 mkesavan13 commented Nov 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

COMPLETES CAI-7375

This pull request addresses

The Epic Embedded Agent Desktop doesn't support WebRTC calls today but the same user can use the WebRTC login in Agent Desktop. Therefore, a visibility toggle is required to handle this on the station login component.

by making the following changes

  • Adding a hideDesktopLogin prop to the Station Login Component.
    • It will hide the desktop login if set to true
    • It will show the desktop login if set to false or not set.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • The testing is done with the amplify link
  • hideDesktopLogin toggle in Station Login widget before login
  • hideDesktopLogin toggle in Station Login widget after login (profileMode=true)

Vidcast

https://app.vidcast.io/share/a86d4fd9-c7c1-447b-b551-46eef98b3503

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Cursor with Claude Sonet 4.5
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document

@mkesavan13 mkesavan13 added the validated Indicates that the PR is ready for actions label Nov 19, 2025
@aws-amplify-us-east-2

aws-amplify-us-east-2 Bot commented Nov 19, 2025

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-554.d1b38q61t1z947.amplifyapp.com

@mkesavan13 mkesavan13 added the run_e2e Add this label to run E2E test for meeting and CC widgets label Nov 19, 2025
Shreyas281299
Shreyas281299 approved these changes Nov 20, 2025
View reviewed changes

@Shreyas281299 Shreyas281299 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is good.
Just have 2 points

  1. Can we have a ticket to remove this flag, becasue we dont wanna support this in the future. (Correct me if Im wrong)
  2. Can you also update the snapshot tests for UT that you added

@mkesavan13

mkesavan13 commented Nov 20, 2025

Copy link
Copy Markdown
Contributor Author

PR is good. Just have 2 points

  1. Can we have a ticket to remove this flag, becasue we dont wanna support this in the future. (Correct me if Im wrong)
  2. Can you also update the snapshot tests for UT that you added

For point 1: No. We would probably keep this one forever because one or the other high confidentiality CRM platforms like Epic wouldn't have WebRTC support from within but want to keep that option open for Agent Desktop.
For point 2: Sorry about that will update snapshots.

@mkesavan13 mkesavan13 removed the run_e2e Add this label to run E2E test for meeting and CC widgets label Nov 21, 2025
@mkesavan13
mkesavan13 merged commit f657c7e into webex:ccwidgets Nov 21, 2025
6 of 8 checks passed
@mkesavan13
mkesavan13 deleted the hide-desktop branch November 21, 2025 12:43
github-actions Bot pushed a commit that referenced this pull request Nov 21, 2025
@semantic-release-bot
chore(release): 1.28.0-ccwidgets.125 [skip ci]
3d520c6 
# [1.28.0-ccwidgets.125](v1.28.0-ccwidgets.124...v1.28.0-ccwidgets.125) (2025-11-21)

### Bug Fixes

* **station-login:** visibility toggle for desktop login ([#554](#554)) ([f657c7e](f657c7e))
@mkesavan13

mkesavan13 commented Nov 21, 2025

Copy link
Copy Markdown
Contributor Author

🎉 This PR is included in version 1.28.0-ccwidgets.125 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shreyas281299 Shreyas281299 Shreyas281299 approved these changes
@rsarika rsarika rsarika approved these changes

Assignees

No one assigned

Labels

released on @ccwidgets validated Indicates that the PR is ready for actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mkesavan13 @Shreyas281299 @rsarika